netdev - Re: [PATCH net 0/9] Fixes for server entries and server filter entries for Chelsio T4/T5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131217.162933.204709940918878458.davem@davemloft.net>
Date:	Tue, 17 Dec 2013 16:29:33 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hariprasad@...lsio.com
Cc:	netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
	roland@...estorage.com, dm@...lsio.com,
	swise@...ngridcomputing.com, leedom@...lsio.com,
	santosh@...lsio.com, kumaras@...lsio.com, nirranjan@...lsio.com
Subject: Re: [PATCH net 0/9] Fixes for server entries and server filter
 entries for Chelsio T4/T5

From: Hariprasad Shenai <hariprasad@...lsio.com>
Date: Mon, 16 Dec 2013 17:42:09 +0530

> This patch series provides miscelleneous fixes for Chelsio T4/T5 adapters
> related to server entries and server filter entries.

You add the sftids_in_use counter, but it is never tested by any code.
It is only initialized to zero, incremented, and decremented.  It
serves no real purpose at all.

Please don't add things like this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html