netdev - RE: [0/2] netxen: bug fix and diagnostics for possible (hardware?) bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31AFFC7280259C4184970ABA9AFE8B938CF85726@avmb3.qlogic.org>
Date:	Tue, 17 Dec 2013 21:50:52 +0000
From:	Manish Chopra <manish.chopra@...gic.com>
To:	David Gibson <david@...son.dropbear.id.au>,
	Sony Chacko <sony.chacko@...gic.com>,
	Rajesh Borundia <rajesh.borundia@...gic.com>
CC:	netdev <netdev@...r.kernel.org>,
	"snagarka@...hat.com" <snagarka@...hat.com>,
	"tcamuso@...hat.com" <tcamuso@...hat.com>,
	"vdasgupt@...hat.com" <vdasgupt@...hat.com>
Subject: RE: [0/2] netxen: bug fix and diagnostics for possible (hardware?)
 bug

>-----Original Message-----
>From: David Gibson [mailto:david@...son.dropbear.id.au]
>Sent: Tuesday, December 17, 2013 10:53 AM
>To: Manish Chopra; Sony Chacko; Rajesh Borundia
>Cc: netdev; snagarka@...hat.com; tcamuso@...hat.com;
>vdasgupt@...hat.com
>Subject: [0/2] netxen: bug fix and diagnostics for possible (hardware?) bug
>
>At Red Hat, we've hit a couple of customer cases with crashes in the netxen driver
>due to list corruption.  This seems to be very rarely triggered, and unfortunately
>the dumps we have don't have enough information to be certain of the cause,
>although we have a possible theory.
>
>I'm suggesting, therefore a patch to add some sanity checking which should help
>to at least localize and mitigate the problem when someone hits it in future.
>Please let me know if there's a better approach to doing this.
>
>That's 2/2.  1/2 is a fix for a clear bug I spotted along the way, but not one that
>could cause the symptoms we've seen.

David,

Having these checks in data path(Rx path) may have some performance impact. It's better to root cause it instead of putting some sanity checks.
We will get back to you on this.


Thanks
Manish

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html