netdev - Re: [PATCH net-next 9/10] lro: remove unused code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131217.172035.1066510228420498241.davem@davemloft.net>
Date:	Tue, 17 Dec 2013 17:20:35 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	stephen@...workplumber.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 9/10] lro: remove unused code

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Mon, 16 Dec 2013 19:54:27 +0000

> On Mon, 2013-12-16 at 10:45 -0800, Stephen Hemminger wrote:
>> This code is not used anywhere in net-next
>> 
>> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
> [...]
>> --- a/net/ipv4/inet_lro.c	2013-10-06 14:48:24.966449847 -0700
>> +++ b/net/ipv4/inet_lro.c	2013-12-12 13:28:43.435225437 -0800
>> @@ -506,23 +506,6 @@ void lro_receive_skb(struct net_lro_mgr
>>  }
>>  EXPORT_SYMBOL(lro_receive_skb);
>>  
>> -void lro_receive_frags(struct net_lro_mgr *lro_mgr,
>> -		       struct skb_frag_struct *frags,
>> -		       int len, int true_size, void *priv, __wsum sum)
>> -{
>> -	struct sk_buff *skb;
>> -
>> -	skb = __lro_proc_segment(lro_mgr, frags, len, true_size, priv, sum);
> 
> You should remove unused functions recursively.  After this, you can
> remove at least __lro_proc_segment(), lro_gen_skb() and lro_add_frags().

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html