netdev - Re: [PATCH v3 net-next] net: vxlan: use custom ndo_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131217154052.6e641cf2@nehalam.linuxnetplumber.net>
Date:	Tue, 17 Dec 2013 15:40:52 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Daniel Borkmann <dborkman@...hat.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next] net: vxlan: use custom ndo_change_mtu
 handler

On Wed, 18 Dec 2013 00:21:08 +0100
Daniel Borkmann <dborkman@...hat.com> wrote:

> When adding a new vxlan device to an "underlying carrier" (here:
> dst->remote_ifindex), the MTU size assigned to the vxlan device
> is the MTU at setup time of the carrier - needed headroom, when
> adding a vxlan device w/o explicit carrier, then it defaults
> to 1500.
> 
> In case of an explicit carrier that supports jumbo frames, we
> currently cannot change vxlan MTU via ip(8) to > 1500 in
> post-setup time, as vxlan driver uses eth_change_mtu() as default
> method for manually setting MTU.
> 
> Hence, use a custom implementation that only falls back to
> eth_change_mtu() in case we didn't use a dev parameter on device
> setup time, and otherwise allow a max MTU setting of the carrier
> incl. adjustment for headroom.
> 
> Reported-by: Shahed Shaikh <shahed.shaikh@...gic.com>
> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>

This code is good thanks.

Acked-by: Stephen Hemminger <stephen@...workplumber.org>

P.s: I wonder if notifier handler would be good to handle changes
to underlying device MTU on the fly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html