netdev - Re: [PATCH] ipv6: clear RTF_EXPIRES when call ip6_rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131217070231.GA11970@order.stressinduktion.org>
Date:	Tue, 17 Dec 2013 08:02:31 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	RongQing Li <roy.qing.li@...il.com>
Cc:	Gao feng <gaofeng@...fujitsu.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: clear RTF_EXPIRES when call ip6_rt_copy

On Tue, Dec 17, 2013 at 02:42:01PM +0800, RongQing Li wrote:
> On 12/17/13, Gao feng <gaofeng@...fujitsu.com> wrote:
> > On 12/17/2013 11:32 AM, RongQing Li wrote:
> >> If the ort->rt6i_flags is RTF_EXPIRES|RTF_ADDRCONF, then rt6_set_from will
> >> not
> >> be called, and new created rt will have RTF_EXPIRES, but dst.expires is 0,
> >> and
> >> dst.from is NULL
> >
> > Ok, but I think you need to add more detail/test purpose of the test case
> > v6LC.4.1.4
> > { Reduce PMTU On-link }. just the number of test case is not good for people
> > to know
> > what's the real problem.
> >
> 
> I have a question, why does we set dst.from only when the ort has flag
> RTF_ADDRCONF
> and RTF_DEFAULT?

Good question. ;)

I wonder, too. In the past from and expires were a union and either from or
expires was allowed to be used. In the commit you referred to this union was
split into seperate fields.

It somehow worked in the past because routes normally have longer timeouts
and the routes will get evicted from the route cache eventually. My guess
is that we can set from unconditionally or copy over the expires value.

This patch already needed quite a long time to review for me and I am still
unsure. :/

Gao, do you still remember why you used RTF_ADDRCONF|RTF_DEFAULT?

Greetings,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html