netdev - Re: [PATCH net-next] xfrm: Namespacify xfrm_policy_sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131217113950.GL31491@secunet.com>
Date:	Tue, 17 Dec 2013 12:39:50 +0100
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Fan Du <fan.du@...driver.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] xfrm: Namespacify xfrm_policy_sk_bundles

On Tue, Dec 17, 2013 at 09:45:46AM +0800, Fan Du wrote:
> 
> 
> On 2013年12月16日 20:23, Steffen Klassert wrote:
> >On Mon, Dec 16, 2013 at 06:26:08PM +0800, Fan Du wrote:
> >>
> >>And also since xfrm_policy_sk_bundles is only used in xfrm_lookup and
> >>__xfrm_garbage_collect, both in process context, no reason we should turn
> >>BH off.
> >
> >Are you sure about that?
> >
> >__xfrm_garbage_collect() is called via dst_alloc() which can be called
> >from softirq and process context.
> 
> Thanks for pointing this out, you are correct! :)
> 
> IMO, xchg can still cover those two cases:
> 1. xfrm_lookup(Process context)  vs  __xfrm_garbage_collect(softirq context)
> 2. xfrm_lookup(Process context)  vs  __xfrm_garbage_collect(Process context when SPD change or dev down)
> 
> I will fix commit message properly on v2 if you are ok with above description.

Yes, please fix and resend.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html