netdev - Re: ieee80211_i.h: shouldn't struct ps_data.tim be aligned unsigned long?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1387358585.13593.40.camel@joe-AO722>
Date:	Wed, 18 Dec 2013 01:23:05 -0800
From:	Joe Perches <joe@...ches.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Jiri Benc <jbenc@...hat.com>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: ieee80211_i.h: shouldn't struct ps_data.tim be aligned unsigned
 long?

On Wed, 2013-12-18 at 10:19 +0100, Johannes Berg wrote:
> On Wed, 2013-12-18 at 00:16 -0800, Joe Perches wrote:
> 
> > Perhaps the
> > 	u8 tim[sizeof...]
> > member should be marked
> > 	__aligned(sizeof(unsigned long))
> > so that the cast to ulong when bitmap_empty
> > is actually forced to be ulong aligned?
> 
> yeah, I suppose that's true.
> 
> > diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
> > index ed5bf8b..e5a9c51 100644
> > --- a/net/mac80211/ieee80211_i.h
> > +++ b/net/mac80211/ieee80211_i.h
> > @@ -245,7 +245,8 @@ struct ps_data {
> >  	/* yes, this looks ugly, but guarantees that we can later use
> >  	 * bitmap_empty :)
> >  	 * NB: don't touch this bitmap, use sta_info_{set,clear}_tim_bit */
> > -	u8 tim[sizeof(unsigned long) * BITS_TO_LONGS(IEEE80211_MAX_AID + 1)];
> > +	u8 tim[sizeof(unsigned long) * BITS_TO_LONGS(IEEE80211_MAX_AID + 1)]
> > +			__aligned(sizeof(unsigned long));
> 
> Care to send a proper patch? Otherwise I'll just re-do it and pick it up
> that way ...

Hi Johannes.

You can redo it easier than applying a patch
from me.

I just noticed it when the reformatting
patch went by.

No need to give a credit or anything.
It's just a nit.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html