netdev - Re: [PATCH net] ipv6: pmtudisc setting not respected with UFO/CORK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131218.175303.1726920497652378353.davem@davemloft.net>
Date:	Wed, 18 Dec 2013 17:53:03 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] ipv6: pmtudisc setting not respected with UFO/CORK

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Mon, 16 Dec 2013 12:36:44 +0100

> Sockets marked with IPV6_PMTUDISC_PROBE (or later IPV6_PMTUDISC_INTERFACE)
> don't respect this setting when the outgoing interface supports UFO.
> 
> We had the same problem in IPv4, which was fixed in commit
> daba287b299ec7a2c61ae3a714920e90e8396ad5 ("ipv4: fix DO and PROBE pmtu
> mode regarding local fragmentation with UFO/CORK").
> 
> Also IPV6_DONTFRAG mode did not care about already corked data, thus
> it may generate a fragmented frame even if this socket option was
> specified. It also did not care about the length of the ipv6 header and
> possible options.
> 
> In the error path allow the user to receive the pmtu notifications via
> both, rxpmtu method or error queue. The user may opted in for both,
> so deliver the notification to both error handlers (the handlers check
> if the error needs to be enqueued).
> 
> Also report back consistent pmtu values when sending on an already
> cork-appended socket.
> 
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Looks good, applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html