netdev - Re: [PATCH] ipv6: sit: update mtu check to take care of gso packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131218.175702.1462184363404956747.davem@davemloft.net>
Date:	Wed, 18 Dec 2013 17:57:02 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	mschmidt@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: sit: update mtu check to take care of gso packets

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 16 Dec 2013 06:31:23 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> While testing my changes for TSO support in SIT devices,
> I was using sit0 tunnel which appears to include nopmtudisc flag.
> 
> But using :
> 
> ip tun add sittun mode sit remote $REMOTE_IPV4 local $LOCAL_IPV4 \
>    dev $IFACE
> 
> We get a tunnel which rejects too long packets because of the mtu check
> which is not yet GSO aware.
> 
> erd:~# ip tunnel
> sittun: ipv6/ip  remote 10.246.17.84  local 10.246.17.83  ttl inherit  6rd-prefix 2002::/16 
> sit0: ipv6/ip  remote any  local any  ttl 64  nopmtudisc 6rd-prefix 2002::/16 
> 
> This patch is based on an excellent report from
> Michal Shmidt.
> 
> In the future, we probably want to extend the MTU check to do the
> right thing for GSO packets...
> 
> Fixes: ("61c1db7fae21 ipv6: sit: add GSO/TSO support")
> Reported-by: Michal Schmidt <mschmidt@...hat.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html