netdev - RE: [PATCH] bnx2x: downgrade "valid ME register value" message level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <979A8436335E3744ADCD3A9F2A2B68A52AF1CF20@SJEXCHMB10.corp.ad.broadcom.com>
Date:	Wed, 18 Dec 2013 06:37:19 +0000
From:	Yuval Mintz <yuvalmin@...adcom.com>
To:	Michal Schmidt <mschmidt@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	Ariel Elior <ariele@...adcom.com>
Subject: RE: [PATCH] bnx2x: downgrade "valid ME register value" message level

> "valid ME register value" is not an error. It should be logged for
> debugging only.
> 
> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>

Yep, that's true; Thanks Michal.

Acked-by: Yuval Mintz <yuvalmin@...adcom.com>

> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
> index efa8a15..3dc2537 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
> @@ -208,7 +208,7 @@ static int bnx2x_get_vf_id(struct bnx2x *bp, u32
> *vf_id)
>  		return -EINVAL;
>  	}
> 
> -	BNX2X_ERR("valid ME register value: 0x%08x\n", me_reg);
> +	DP(BNX2X_MSG_IOV, "valid ME register value: 0x%08x\n", me_reg);
> 
>  	*vf_id = (me_reg & ME_REG_VF_NUM_MASK) >>
> ME_REG_VF_NUM_SHIFT;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html