netdev - Re: [PATCH net-next] netfilter: ipvs: remove the unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1312190912090.1749@ja.home.ssi.bg>
Date:	Thu, 19 Dec 2013 09:17:17 +0200 (EET)
From:	Julian Anastasov <ja@....bg>
To:	Wang Weidong <wangweidong1@...wei.com>
cc:	wensong@...ux-vs.org, horms@...ge.net.au,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] netfilter: ipvs: remove the unused variable


	Hello,

On Thu, 19 Dec 2013, Wang Weidong wrote:

> when I built the netfilter, I got that:
> net/netfilter/ipvs/ip_vs_sync.c: In function sync_thread_master’:
> net/netfilter/ipvs/ip_vs_sync.c:1640: warning: unused variable ‘ret’

	There is another patch that we plan to apply but
due to possible merge conflict it was delayed:

http://marc.info/?t=138426695600002&r=1&w=2
http://marc.info/?t=138426469400008&r=1&w=2

	May be it is time to apply it...

> Signed-off-by: Wang Weidong <wangweidong1@...wei.com>
> ---
>  net/netfilter/ipvs/ip_vs_sync.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
> index f63c238..d258125 100644
> --- a/net/netfilter/ipvs/ip_vs_sync.c
> +++ b/net/netfilter/ipvs/ip_vs_sync.c
> @@ -1637,7 +1637,7 @@ static int sync_thread_master(void *data)
>  			continue;
>  		}
>  		while (ip_vs_send_sync_msg(tinfo->sock, sb->mesg) < 0) {
> -			int ret = __wait_event_interruptible(*sk_sleep(sk),
> +			__wait_event_interruptible(*sk_sleep(sk),
>  						   sock_writeable(sk) ||
>  						   kthread_should_stop());
>  			if (unlikely(kthread_should_stop()))
> -- 
> 1.7.12

Regards

--
Julian Anastasov <ja@....bg>