netdev - Re: [PATCH net-next] vxlan: make get_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.03.1312191158170.30247@intel.com>
Date:	Thu, 19 Dec 2013 12:00:46 -0800 (PST)
From:	Joseph Gasparakis <joseph.gasparakis@...el.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
cc:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] vxlan: make get_rx_port static



On Fri, 13 Dec 2013, Stephen Hemminger wrote:

> Make local function static, only used in vxlan itself right now.
> Maybe someone had ideas about offload, but they can expose it when
> they send their offload upstream.
> 
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
> 
> --- a/drivers/net/vxlan.c	2013-12-12 11:48:17.057855220 -0800
> +++ b/drivers/net/vxlan.c	2013-12-12 11:56:55.949774139 -0800
> @@ -2039,7 +2039,7 @@ static struct device_type vxlan_type = {
>   * supply the listening VXLAN udp ports. Callers are expected
>   * to implement the ndo_add_vxlan_port.
>   */
> -void vxlan_get_rx_port(struct net_device *dev)
> +static void vxlan_get_rx_port(struct net_device *dev)
>  {
>  	struct vxlan_sock *vs;
>  	struct net *net = dev_net(dev);
> --- a/include/net/vxlan.h	2013-12-12 11:48:17.057855220 -0800
> +++ b/include/net/vxlan.h	2013-12-12 11:56:55.949774139 -0800
> @@ -41,11 +41,4 @@ __be16 vxlan_src_port(__u16 port_min, __
>  /* IPv6 header + UDP + VXLAN + Ethernet header */
>  #define VXLAN6_HEADROOM (40 + 8 + 8 + 14)
>  
> -#if IS_ENABLED(CONFIG_VXLAN)
> -void vxlan_get_rx_port(struct net_device *netdev);
> -#else
> -static inline void vxlan_get_rx_port(struct net_device *netdev)
> -{
> -}
> -#endif
>  #endif
> --

Please do not apply this patch. Jeff Kirsher is about to send a patch that 
takes advantage of vxlan_get_rx_port in i40e.

> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html