netdev - Re: [PATCH net] net: i40e: fix shifting error in i40e_led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Dec 2013 14:04:36 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Daniel Borkmann <dborkman@...hat.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: i40e: fix shifting error in i40e_led_get

On Thu, 2013-12-19 at 22:57 +0100, Daniel Borkmann wrote:
> In function i40e_led_get(), we fetch the LED mode from the GPIO
> registers and extract it from gpio_val. However, regardless of
> the outcome of the fetched value in gpio_val, the calculation
> to extract the mode will always be 0, as we do the following:
> 
>   (gpio_val & (61440U /* 0xf << 12 */)) >> 17
> 
> Instead of I40E_GLGEN_GPIO_CTL_INT_MODE_SHIFT, we need to use
> I40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT to fix this.
> 
> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>
> ---
>  Seems like this is still unfixed, so sending to netdev.
> 
>  drivers/net/ethernet/intel/i40e/i40e_common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks Daniel, I may already have a patch in my queue that fixes this,
but if not, I will add this to my queue.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)