netdev - RE: FEC performance degradation with certain packet sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1387494299.19078.378.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 19 Dec 2013 15:04:59 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	"fugang.duan@...escale.com" <fugang.duan@...escale.com>
Cc:	Hector Palacios <hector.palacios@...i.com>,
	Marek Vasut <marex@...x.de>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Fabio.Estevam@...escale.com" <Fabio.Estevam@...escale.com>,
	"shawn.guo@...aro.org" <shawn.guo@...aro.org>,
	"l.stach@...gutronix.de" <l.stach@...gutronix.de>,
	"Frank.Li@...escale.com" <Frank.Li@...escale.com>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: RE: FEC performance degradation with certain packet sizes

On Thu, 2013-12-19 at 02:44 +0000, fugang.duan@...escale.com wrote:

> Enet IP don't support tso feature.
> 
> I will reproduce the issue in imx6q/dl sd platform, and analyze the issue.
> Previous test, we don't use netpipe tool test ethernet performance.

drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c seems broken...

If tx_skb_align_workaround() returns NULL, returning NETDEV_TX_BUSY 
is the worst possible thing to do.

Packet should be dropped instead.

Probably not related to your issue.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html