netdev - Re: [PATCH v3 5/8] drivers: net: Mark functions as static in 3945-debug.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131219.185223.661280204547522817.davem@davemloft.net>
Date:	Thu, 19 Dec 2013 18:52:23 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	rashika.kheria@...il.com
Cc:	sgruszka@...hat.com, linville@...driver.com,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, josh@...htriplett.org
Subject: Re: [PATCH v3 5/8] drivers: net: Mark functions as static in
 3945-debug.c

From: Rashika Kheria <rashika.kheria@...il.com>
Date: Thu, 19 Dec 2013 14:23:49 +0530

> This patch marks the function il3945_ucode_rx_stats_read(),
> il3945_ucode_tx_stats_read() and il3945_ucode_general_stats_read() in
> 3945-debug.c as static because they are not used outside this file.
> 
> Thus, it also removes the following warnings in
> wireless/iwlegacy/3945-debug.c:
> 
> drivers/net/wireless/iwlegacy/3945-debug.c:52:1: warning: no previous prototype for ‘il3945_ucode_rx_stats_read’ [-Wmissing-prototypes]
> drivers/net/wireless/iwlegacy/3945-debug.c:317:1: warning: no previous prototype for ‘il3945_ucode_tx_stats_read’ [-Wmissing-prototypes]
> drivers/net/wireless/iwlegacy/3945-debug.c:407:1: warning: no previous prototype for ‘il3945_ucode_general_stats_read’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>

Applied.