netdev - Re: [PATCH v3 1/8] drivers: net: Mark functions as static in qlcnic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131219.185201.2268644156166690269.davem@davemloft.net>
Date:	Thu, 19 Dec 2013 18:52:01 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	rashika.kheria@...il.com
Cc:	linux-kernel@...r.kernel.org, himanshu.madhani@...gic.com,
	rajesh.borundia@...gic.com, shahed.shaikh@...gic.com,
	jitendra.kalsaria@...gic.com, sony.chacko@...gic.com,
	sucheta.chakraborty@...gic.com, linux-driver@...gic.com,
	netdev@...r.kernel.org, josh@...htriplett.org
Subject: Re: [PATCH v3 1/8] drivers: net: Mark functions as static in
 qlcnic_io.c

From: Rashika Kheria <rashika.kheria@...il.com>
Date: Thu, 19 Dec 2013 14:17:27 +0530

> This patch marks the function qlcnic_enable_tx_intr(),
> qlcnic_83xx_enable_tx_intr() and qlcnic_83xx_disable_tx_intr() in
> qlcnic_io.c as static because they are not used outside this file.
> 
> Thus, it also removes the following warnings in
> ethernet/qlogic/qlcnic/qlcnic_io.c:
> 
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:130:13: warning: no previous prototype for ‘qlcnic_enable_tx_intr’ [-Wmissing-prototypes]
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:147:13: warning: no previous prototype for ‘qlcnic_83xx_enable_tx_intr’ [-Wmissing-prototypes]
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:153:13: warning: no previous prototype for ‘qlcnic_83xx_disable_tx_intr’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>

Applied.