netdev - Re: [patch ipsec-next 4/5] xfrm: fix checkpatch error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Dec 2013 17:50:12 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Chen Weilong <chenweilong@...wei.com>,
	steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
	davem@...emloft.net
CC:	netdev@...r.kernel.org
Subject: Re: [patch ipsec-next 4/5] xfrm: fix checkpatch error

Hello.

On 20-12-2013 14:49, Chen Weilong wrote:

> From: Weilong Chen <chenweilong@...wei.com>

> Fix that "else should follow close brace '}'".

> Signed-off-by: Weilong Chen <chenweilong@...wei.com>
> ---
>   net/xfrm/xfrm_policy.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

> diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
> index fbc72b4..0ed4770 100644
> --- a/net/xfrm/xfrm_policy.c
> +++ b/net/xfrm/xfrm_policy.c
> @@ -1316,8 +1316,7 @@ xfrm_tmpl_resolve_one(struct xfrm_policy *policy, const struct flowi *fl,
>   			error = (x->km.state == XFRM_STATE_ERROR ?
>   				 -EINVAL : -EAGAIN);
>   			xfrm_state_put(x);
> -		}
> -		else if (error == -ESRCH)
> +		} else if (error == -ESRCH)
>   			error = -EAGAIN;

    According to CodingStyle, both branches of *if* should have {}, if one has 
it. You may as well fix this.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html