netdev - Re: [PATCH v2] arc_emac: fix potential use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1387548366.32574.5.camel@abrodkin-8560l>
Date:	Fri, 20 Dec 2013 14:06:07 +0000
From:	Alexey Brodkin <Alexey.Brodkin@...opsys.com>
To:	"eric.dumazet@...il.com" <eric.dumazet@...il.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"richardcochran@...il.com" <richardcochran@...il.com>
Subject: Re: [PATCH v2] arc_emac: fix potential use after free

On Thu, 2013-12-19 at 18:10 -0800, Eric Dumazet wrote:
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> 
> skb_tx_timestamp(skb) should be called _before_ TX completion
> has a chance to trigger, otherwise it is too late and we access
> freed memory.
> 
> Fixes: e4f2379db6c6 ("ethernet/arc/arc_emac - Add new driver")

Hi Eric,

thanks for this fix.

Indeed I missed this part and description of "skb_tx_timestamp" which
clearly directs to use it earlier:
=======
 * skb_tx_timestamp() - Driver hook for transmit timestamping
 *
 * Ethernet MAC Drivers should call this function in their hard_xmit()
 * function immediately before giving the sk_buff to the MAC hardware.
=======

-Alexey
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html