netdev - Re: [RFC PATCH] net, gro: fix the truesize of all fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1387550571.19078.436.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 20 Dec 2013 06:42:51 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Zhi Yong Wu <zwu.kernel@...il.com>
Cc:	Linux Netdev List <netdev@...r.kernel.org>,
	Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
Subject: Re: [RFC PATCH] net, gro: fix the truesize of all fragments

On Fri, 2013-12-20 at 22:37 +0800, Zhi Yong Wu wrote:
> On Fri, Dec 20, 2013 at 10:28 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:

> > Nope, this patch is not needed.
> >
> > truesize is about tracking the memory we allocated, not the memory we
> > really use.
> wow, i forgot this, thanks for yor reminder.
> >
> > What exact issue do you have ? I suspect a bug in a driver.
> I didn't hit any issue, but found this when i read gro related code. a
> but in a driver? sorry, i don't know, look forward to seeing your fix.

No, I have no particular issue with this code, I thought you had a
problem on a running machine.

If you found this by code review, then everything is fine, and
no patch is needed at this point.

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html