netdev - possible rose recvmsg behavior change after msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131220160207.GC29632@breakpoint.cc>
Date:	Fri, 20 Dec 2013 17:02:07 +0100
From:	Florian Westphal <fw@...len.de>
To:	hannes@...essinduktion.org
Cc:	netdev <netdev@...r.kernel.org>, linux-hams@...r.kernel.org
Subject: possible rose recvmsg behavior change after msg_namelen fixes

Hi.

recvmsg handler in net/rose/af_rose.c performs size-check
on  ->msg_namelen:

if (msg->msg_namelen >= sizeof(struct full_sockaddr_rose)) {
 /* something */
} else {
  /* else */
}

Now that msg_namelen is zeroed before the handler calls we always
hit the 'else' branch.

TBH i don't comprehend how this was/is supposed to work.

Could someone who is familiar with AF_ROSE look at this, before
I send untested patch that blindly chops off code?

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html