netdev - Re: [PATCH net-next] ipv6: trival improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJFZqHz_tvawRCuCqPLRDrEPz-Q-AH-gnOcSUX_tfgU=gHuD=Q@mail.gmail.com>
Date:	Fri, 20 Dec 2013 09:01:22 +0800
From:	RongQing Li <roy.qing.li@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ipv6: trival improvements

On Fri, Dec 20, 2013 at 3:45 AM, David Miller <davem@...emloft.net> wrote:
> From: roy.qing.li@...il.com
> Date: Thu, 19 Dec 2013 14:18:52 +0800
>
>> From: Li RongQing <roy.qing.li@...il.com>
>>
>> 1. remove the unnecessary setting rt.rt6i_metric to 0 since memset() has clear
>> them.
>> 2. call ip6_rt_put to release rt only when rt is not null in addrconf_prefix_rcv.
>>
>> Signed-off-by: Li RongQing <roy.qing.li@...il.com>
>
> ip6_rt_put() transparently handles NULL just fine, don't special
> case it like this.

Yes, ip6_rt_put() can handles NULL, but this change can free cpu to do judgement
one time if rt is NULL.

Thanks

-Roy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html