netdev - RE: [net-next v2 11/16] i40e: remove chatty log messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Dec 2013 18:00:23 +0000
From:	"Williams, Mitch A" <mitch.a.williams@...el.com>
To:	"Williams, Mitch A" <mitch.a.williams@...el.com>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Subject: RE: [net-next v2 11/16] i40e: remove chatty log messages



> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org] On
> Behalf Of Williams, Mitch A
> Sent: Friday, December 20, 2013 9:40 AM
> To: Sergei Shtylyov; Kirsher, Jeffrey T; davem@...emloft.net
> Cc: netdev@...r.kernel.org; gospo@...hat.com; sassmann@...hat.com;
> Brandeburg, Jesse
> Subject: RE: [net-next v2 11/16] i40e: remove chatty log messages
> 
> 
> 
> > -----Original Message-----
> > From: Sergei Shtylyov [mailto:sergei.shtylyov@...entembedded.com]
> > Sent: Friday, December 20, 2013 10:18 AM
> > To: Kirsher, Jeffrey T; davem@...emloft.net; Williams, Mitch A
> > Cc: netdev@...r.kernel.org; gospo@...hat.com; sassmann@...hat.com;
> > Brandeburg, Jesse
> > Subject: Re: [net-next v2 11/16] i40e: remove chatty log messages
> >
> > On 12/20/2013 07:46 PM, Jeff Kirsher wrote:
> >
> > > From: Mitch Williams <mitch.a.williams@...el.com>
> >
> > > Don't complain when we disable queues that are already disable, or
> > > enable them when they're already enabled. This removes a bunch of bogus
> > > log messages that we see at every VF reset.
> >
> > > Change-Id: Ia127be572abdccc48a53d8c43f8a07b8bb920de1
> > > Signed-off-by: Mitch Williams <mitch.a.williams@...el.com>
> > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> > > Tested-by: Kavindya Deegala <kavindya.s.deegala@...el.com>
> > > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> > > ---
> > >   drivers/net/ethernet/intel/i40e/i40e_main.c | 16 +++-------------
> > >   1 file changed, 3 insertions(+), 13 deletions(-)
> >
> > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
> > b/drivers/net/ethernet/intel/i40e/i40e_main.c
> > > index c0f78bc..38e07e6 100644
> > > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> > > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> > > @@ -2988,21 +2988,11 @@ static int i40e_vsi_control_tx(struct i40e_vsi
> > *vsi, bool enable)
> > >   		} while (j-- && ((tx_reg >> I40E_QTX_ENA_QENA_REQ_SHIFT)
> > >   			       ^ (tx_reg >> I40E_QTX_ENA_QENA_STAT_SHIFT)) &
> 1);
> > >
> > > -		if (enable) {
> > > -			/* is STAT set ? */
> > > -			if ((tx_reg & I40E_QTX_ENA_QENA_STAT_MASK)) {
> > > -				dev_info(&pf->pdev->dev,
> > > -					 "Tx %d already enabled\n", i);
> > > +		/* Skip if the queue is already in the requested state */
> > > +		if (enable && (tx_reg & I40E_QTX_ENA_QENA_STAT_MASK))
> > >   				continue;
> >
> >     This line seems over-indented now.
> >
> > > -			}
> > > -		} else {
> > > -			/* is !STAT set ? */
> > > -			if (!(tx_reg & I40E_QTX_ENA_QENA_STAT_MASK)) {
> > > -				dev_info(&pf->pdev->dev,
> > > -					 "Tx %d already disabled\n", i);
> > > +		if (!enable && !(tx_reg & I40E_QTX_ENA_QENA_STAT_MASK))
> > >   				continue;
> >
> >     This one too.
> >
> > WBR, Sergei
> 
> Sergei, if you look at the source instead of the patch, you'll see that
> these are correct. The whole thing is inside a for loop, so it should
> properly be indented two tabs.
> 
> -Mitch

Doh! Jeff pointed out to me that you are indeed correct, Sergei. I was looking at the if lines, not the continue lines. We'll fix this.

-Mitch

> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html