netdev - Re: [net-next v2 11/16] i40e: remove chatty log messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Dec 2013 10:31:32 -0800
From:	Joe Perches <joe@...ches.com>
To:	"Williams, Mitch A" <mitch.a.williams@...el.com>
Cc:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Subject: Re: [net-next v2 11/16] i40e: remove chatty log messages

On Fri, 2013-12-20 at 18:04 +0000, Williams, Mitch A wrote:
> > From: Joe Perches [mailto:joe@...ches.com]
[]
> > this code is inconsistent and might be
> > nicer using the same form:
> > 
> > 		/* Skip if the queue is already in the requested state */
> > 		if (enable && (tx_reg & I40E_QTX_ENA_QENA_STAT_MASK))
> > 			continue;
> > 		if (!enable && !(tx_reg & I40E_QTX_ENA_QENA_STAT_MASK))
> > 			continue;
> > 
> > [...]
> > 
> > 		/* wait for the change to finish */
> > 		for (j = 0; j < 10; j++) {
> > 			tx_reg = rd32(hw, I40E_QTX_ENA(pf_q));
> > 			if (enable) {
> > 				if ((tx_reg & I40E_QTX_ENA_QENA_STAT_MASK))
> > 					break;
> > 			} else {
> > 				if (!(tx_reg & I40E_QTX_ENA_QENA_STAT_MASK))
> > 					break;
> > 			}
> > 
> > Perhaps the first form should be like the second
> > 
> > 	if (enable) {
> > 		if (tx_reg & I40E_QTX_ENA_QENA_STAT_MASK)
> > 			continue;
> > 	} else {
> > 		if (!(tx_reg & I40E_QTX_ENA_QENA_STAT_MASK))
> > 			continue;
> > 	}
> > 
> > or maybe both should be
> > 
> > 	bool mask = tx_reg & I40E_QTX_ENA_QENA_STAT_MASK;
> > 	if (enable ^ mask)
[]
> I see what you mean about the inconsistent logic. Since it's not
> crucial, I think I'd prefer to fix this in a separate patch in the
> future. (I'll implement it today, but it takes a while to get through
> our internal validation process.)

Whenever, no worries, it's just a nit.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html