netdev - Re: [PATCH net] tg3: Expand 4g_overflow_test workaround to skb fragments of any size.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52B39E6B.1090305@broadcom.com>
Date:	Thu, 19 Dec 2013 17:33:31 -0800
From:	Nithin Nayak Sujir <nsujir@...adcom.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<stable@...r.kernel.org>, Michael Chan <mchan@...adcom.com>
Subject: Re: [PATCH net] tg3: Expand 4g_overflow_test workaround to skb fragments
 of any size.


>> -	return (base > 0xffffdcc0) && (base + len + 8 < base);
>> +	return (base + len + 8 < base);
>>   }
>
> And it is actually faster ;)
>
> What is 8 value exactly ?
>
>

Some older devices needed to be at least 8 bytes away from the boundary. For 
simplicity we use the same check for all devices.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html