netdev - Re: [Patch net-next 1/4] net_sched: act: clean up notification functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpWPSUJJcUFVy6be1qmWd6EcGqK-ZNUkegdg4QsRSBhZRQ@mail.gmail.com>
Date:	Thu, 19 Dec 2013 17:39:13 -0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Jamal Hadi Salim <jhs@...atatu.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch net-next 1/4] net_sched: act: clean up notification functions

On Thu, Dec 19, 2013 at 6:40 AM, Jamal Hadi Salim <jhs@...atatu.com> wrote:
> On 12/18/13 19:48, Cong Wang wrote:
>>
>> On Wed, Dec 18, 2013 at 4:36 PM, Cong Wang <xiyou.wangcong@...il.com>
>> wrote:
>>>
>>> -               if (ret > 0)
>>> -                       return 0;
>>> -               return ret;
>>> -       }
>>> +       else /* delete */
>>> +               ret = tcf_del_notify(net, n, &actions, portid);
>>
>>
>> This piece doesn't look correct. :-) I will fix it.
>>
>
> It is not as trivial and i dont think you have the correct tests to
> vet it.
> Please give me until this weekend to test your other changes
> that are already in.
> I also had some changes i wanted to get in. Then I will review
> and maybe test this as well...


Sure. Meanwhile, I will test this action deletion case and send
the updated patches for you to test in the weekend.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html