netdev - Re: [PATCH] arc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1387505115.19078.417.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 19 Dec 2013 18:05:15 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>,
	Alexey Brodkin <Alexey.Brodkin@...opsys.com>,
	Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH] arc_emac: fix

On Thu, 2013-12-19 at 17:58 -0800, Eric Dumazet wrote:
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> 
> skb_tx_timestamp(skb) should be called _before_ TX completion
> has a chance to trigger, otherwise it is too late and we access
> freed memory.
> 
> Fixes: e4f2379db6c6 ("ethernet/arc/arc_emac - Add new driver")
> From: Eric Dumazet <edumazet@...gle.com>
> Cc: Alexey Brodkin <Alexey.Brodkin@...opsys.com>
> Cc: Richard Cochran <richardcochran@...il.com>
> ---
>  drivers/net/ethernet/arc/emac_main.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c
> index b2ffad1304d2..248baf6273fb 100644
> --- a/drivers/net/ethernet/arc/emac_main.c
> +++ b/drivers/net/ethernet/arc/emac_main.c
> @@ -565,6 +565,8 @@ static int arc_emac_tx(struct sk_buff *skb, struct net_device *ndev)
>  	/* Make sure pointer to data buffer is set */
>  	wmb();
>  
> +	skb_tx_timestamp(skb);
> +
>  	*info = cpu_to_le32(FOR_EMAC | FIRST_OR_LAST_MASK | len);
>  
>  	/* Increment index to point to the next BD */
> @@ -579,8 +581,6 @@ static int arc_emac_tx(struct sk_buff *skb, struct net_device *ndev)
>  
>  	arc_reg_set(priv, R_STATUS, TXPL_MASK);
>  
> -	skb_tx_timestamp(skb);
> -
>  	return NETDEV_TX_OK;
>  }
>  

Sorry I messed patch title, will resend


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html