netdev - Re: [PATCH 02/11] staging: r8188eu: Remove wrapper around spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131220071408.GK28413@mwanda>
Date:	Fri, 20 Dec 2013 10:14:08 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 02/11] staging: r8188eu: Remove wrapper around
 spin_lock_bh

On Thu, Dec 19, 2013 at 10:38:34PM -0600, Larry Finger wrote:
> Some comment lines that mentioned spin_lock_bh() are also removed.
> 
> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
> @@ -1509,10 +1509,6 @@ _func_enter_;
>  
>  	rtw_p2p_set_state(pwdinfo, P2P_STATE_FIND_PHASE_SEARCH);
>  
> -	_enter_critical_bh(&pmlmepriv->lock, &irqL);
> -	_exit_critical_bh(&pmlmepriv->lock, &irqL);
> -
> -
>  _func_exit_;
>  }

This is a functionality change that slipped in.  This is like
spin_unlock_wait() where you want to wait until the lock is released.

In this code it's probably unintended?  But don't put these things into
a patch without mentioning it.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html