netdev - Re: [PATCH 2/2] net_sched: optimize tcf_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXcK26T1zrg0bOMfay4PP2HU3cuuRi9JyKBTZG8XY4fZg@mail.gmail.com>
Date:	Fri, 20 Dec 2013 16:12:59 -0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 2/2] net_sched: optimize tcf_match_indev()

On Fri, Dec 20, 2013 at 3:59 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Fri, 2013-12-20 at 15:49 -0800, Cong Wang wrote:
>> On Thu, Dec 19, 2013 at 5:34 PM, Cong Wang <xiyou.wangcong@...il.com> wrote:
>> > tcf_match_indev() is called in fast path, it is not wise to
>> > search for a netdev by ifindex and then compare by its name,
>> > just compare the ifindex.
>> >
>> > This will also save some bytes from the core struct of u32.
>> >
>> > Cc: Jamal Hadi Salim <jhs@...atatu.com>
>> > Cc: David S. Miller <davem@...emloft.net>
>> > Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
>>
>>
>> Jamal, any comments on this patch itself?
>
> How device renaming (dev_change_name()) is handled ?
>
>

Good point.

Before my patch, when the dev name gets changes, indev will not
be matched any more. After my patch, it can still be matched
and will be displayed with the new name (ifindex doesn't change).

So, I think we probably need the latter behavior, otherwise we
have to rename the indev manually too in order to match its new
name.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html