netdev - Re: [PATCH net-next] sctp: fix missing include file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <A1B7221A-6C6E-4B3B-8A7A-8492D04049D2@cumulusnetworks.com>
Date:	Sat, 21 Dec 2013 07:19:03 -0800
From:	Scott Feldman <sfeldma@...ulusnetworks.com>
To:	Daniel Borkmann <dborkman@...hat.com>
Cc:	David Miller <davem@...emloft.net>, vyasevich@...il.com,
	nhorman@...driver.com, Netdev <netdev@...r.kernel.org>,
	Roopa Prabhu <roopa@...ulusnetworks.com>,
	Shrijeet Mukherjee <shm@...ulusnetworks.com>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	"linux-sctp@...r.kernel.org" <linux-sctp@...r.kernel.org>
Subject: Re: [PATCH net-next] sctp: fix missing include file


On Dec 21, 2013, at 1:44 AM, Daniel Borkmann <dborkman@...hat.com> wrote:

> On 12/21/2013 06:00 AM, David Miller wrote:
>> From: Scott Feldman <sfeldma@...ulusnetworks.com>
>> Date: Fri, 20 Dec 2013 18:51:10 -0800
>> 
>>> Compile error reported by Jim Davis on netdev.
>>> 
>>> ip6_sk_accept_pmtu() needs net/ip6_route.h
>>> 
>>> Signed-off-by: Scott Feldman <sfeldma@...ulusnetworks.com>
>> 
>> Applied, thanks.
> 
> Sorry for the late reply as I'm on travel with limited connectivity.
> 
> Scott, this fix is not correct, and probably should be reverted. The
> correct one was already in patchwork under [1]. In SCTP, we have
> net/sctp/ipv6.c for all IPv6 related functions. Also there, this
> include file is already present.
> 
> Thanks !
> 
> [1] http://patchwork.ozlabs.org/patch/303308/

Oops, sorry, two ships passing, etc.  I should have looked under patchwork first.

David, please revert my change ac0917f2 pending Daniel’s fix.

-scott--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html