netdev - Re: [PATCH v2] can: ti_hecc: Replace platform dependency with ARM dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52B608D1.2030105@pengutronix.de>
Date:	Sat, 21 Dec 2013 22:32:01 +0100
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>,
	netdev@...r.kernel.org, linux-can@...r.kernel.org
Subject: Re: [PATCH v2] can: ti_hecc: Replace platform dependency with ARM
 dependency

On 12/21/2013 11:16 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 12/22/2013 12:06 AM, Marc Kleine-Budde wrote:
> 
>>>>> OMAP's ti_hecc driver is used to support the CAN controller on many
>>>>> omap2plus
>>>>> SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x), so it's wrong to
>>>>> make this
>>>>> depend on OMAP3 only. Take an extra step, to get wider build
>>>>> coverage, and make
>>>>> the driver depend on ARM.
> 
>>>>      To have a real wide coverage, it's probably worth adding '||
>>>> COMIPLE_TEXT'
>>>> to 'depends on ARCH_OMAP2PLUS'?
> 
>>> Yup, and that was my exact proposal on my reply to v1 (which I forgot
>>> to detail
>>> in v2). I'd say it's Marc's call.
> 
>> Convinced, I've added the v1 of this patch to can-next together with a
>> || COMIPLE_TEXT.
> 
>    Sorry, I meant COMPILE_TEST, of course. :-<

lol, I copy/pasted the || COMIPLE_TEXT from you, but in the patch I
added the correct COMPILE_TEST:

-       depends on ARCH_OMAP3
+       depends on ARCH_OMAP2PLUS || COMPILE_TEST

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (260 bytes)