| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1387675868-18221-1-git-send-email-Larry.Finger@lwfinger.net> Date: Sat, 21 Dec 2013 19:31:08 -0600 From: Larry Finger <Larry.Finger@...inger.net> To: gregkh@...uxfoundation.org Cc: netdev@...r.kernel.org, devel@...verdev.osuosl.org, Larry Finger <Larry.Finger@...inger.net> Subject: [RFC] staging: r8188eu: Fix sparse warnings in core/rtw_br_ext.c Please tell me if the following fixes are appropriate. In particular, I am uncertain of the __force attributes. Thanks, Larry Sparse lists the following: CHECK drivers/staging/rtl8188eu/core/rtw_br_ext.c drivers/staging/rtl8188eu/core/rtw_br_ext.c:1156:63: warning: restricted __sum16 degrades to integer drivers/staging/rtl8188eu/core/rtw_br_ext.c:1160:69: warning: incorrect type in assignment (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:1160:69: expected restricted __sum16 [usertype] check drivers/staging/rtl8188eu/core/rtw_br_ext.c:1160:69: got int --- drivers/staging/rtl8188eu/core/rtw_br_ext.c | 47 +++++++++++++++-------------- 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_br_ext.c b/drivers/staging/rtl8188eu/core/rtw_br_ext.c index 5425bc5..54a706f 100644 --- a/drivers/staging/rtl8188eu/core/rtw_br_ext.c +++ b/drivers/staging/rtl8188eu/core/rtw_br_ext.c @@ -1153,11 +1154,11 @@ void dhcp_flag_bcast(struct adapter *priv, struct sk_buff *skb) /* or BROADCAST flag */ dhcph->flags |= htons(BROADCAST_FLAG); /* recalculate checksum */ - sum = ~(udph->check) & 0xffff; + sum = (__force int)(~(udph->check)) & 0xffff; sum += be16_to_cpu(dhcph->flags); while (sum >> 16) sum = (sum & 0xffff) + (sum >> 16); - udph->check = ~sum; + udph->check = (__force __sum16)(~sum); } } } -- 1.8.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists