netdev - Re: [PATCH resend net-next 1/2] net_sched: replace pr_warning with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1387761616.22671.40.camel@joe-AO722>
Date:	Sun, 22 Dec 2013 17:20:16 -0800
From:	Joe Perches <joe@...ches.com>
To:	Yang Yingliang <yangyingliang@...wei.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH resend net-next 1/2] net_sched: replace pr_warning with
 pr_warn

On Mon, 2013-12-23 at 09:06 +0800, Yang Yingliang wrote:
> Prefer pr_warn(... to pr_warning(...

Couple of trivial comments:

> diff --git a/net/sched/sch_dsmark.c b/net/sched/sch_dsmark.c
[]
> @@ -303,8 +303,8 @@ static struct sk_buff *dsmark_dequeue(struct Qdisc *sch)
>  		 * and don't need yet another qdisc as a bypass.
>  		 */
>  		if (p->mask[index] != 0xff || p->value[index])
> -			pr_warning("dsmark_dequeue: unsupported protocol %d\n",
> -				   ntohs(skb->protocol));
> +			pr_warn("dsmark_dequeue: unsupported protocol %d\n",
> +				ntohs(skb->protocol));

When converting messages with embedded function names,
consider using "%s: ...", __func__

> diff --git a/net/sched/sch_gred.c b/net/sched/sch_gred.c
[]
> @@ -370,8 +370,8 @@ static inline int gred_change_table_def(struct Qdisc *sch, struct nlattr *dps)
>  
>  	for (i = table->DPs; i < MAX_DPs; i++) {
>  		if (table->tab[i]) {
> -			pr_warning("GRED: Warning: Destroying "
> -				   "shadowed VQ 0x%x\n", i);
> +			pr_warn("GRED: Warning: Destroying "
> +				"shadowed VQ 0x%x\n", i);

When converting formats split across multiple lines,
please coalesce the format fragments like:

			pr_warn("GRED: Warning: Destroying shadowed V0 0x%x\n",
				i);


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html