netdev - Re: [PATCH net-next 4/6] bnx2x: no error when RSS configuration fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Dec 2013 01:36:37 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Yuval Mintz <yuvalmin@...adcom.com>, davem@...emloft.net,
	netdev@...r.kernel.org
CC:	ariele@...adcom.com
Subject: Re: [PATCH net-next 4/6] bnx2x: no error when RSS configuration fails

Hello.

On 12/23/2013 09:44 PM, Yuval Mintz wrote:

> It's possible for VMs with older versions of bnx2x to run over a hypervisor
> with latest driver. If a VF in such a VM does not support RSS configuration,
> the PF driver in the hypervisor will print an error message to system logs.

> This changes the error message into a debug message, as this is very likely
> a false alarm for an older VF (i.e., VF manages to work properly; PF simply
> cannot configure the additional queues for it).

> Signed-off-by: Yuval Mintz <yuvalmin@...adcom.com>
> Signed-off-by: Ariel Elior <ariele@...adcom.com>
> ---
>   drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)

> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
> index efa8a15..c7aaf5b 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
> @@ -800,14 +800,18 @@ int bnx2x_vfpf_config_rss(struct bnx2x *bp,
>   	}
>
>   	if (resp->hdr.status != PFVF_STATUS_SUCCESS) {
> -		BNX2X_ERR("failed to send rss message to PF over Vf PF channel %d\n",
> -			  resp->hdr.status);
> -		rc = -EINVAL;
> +		/* Since older drivers don't support this feature (and VF has
> +		 * no way of knowing other than failing this), don't propogate

    Sorry for the grammar nitpicking but it's "propAgate".

> +		 * an error in this case.
> +		 */
> +		DP(BNX2X_MSG_IOV,
> +		   "Failed to send rss message to PF over VF-PF channel [%d]\n",
> +		   resp->hdr.status);
>   	}

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html