netdev - Re: [PATCH 09/21] batman-adv: slight optimization of addr compare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52B7F853.8050806@meshcoding.com>
Date:	Mon, 23 Dec 2013 09:46:11 +0100
From:	Antonio Quartulli <antonio@...hcoding.com>
To:	Ding Tianhong <dingtianhong@...wei.com>,
	Marek Lindner <mareklindner@...mailbox.ch>,
	Simon Wunderlich <sw@...onwunderlich.de>,
	"David S. Miller" <davem@...emloft.net>,
	b.a.t.m.a.n@...ts.open-mesh.org, Netdev <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 09/21] batman-adv: slight optimization of addr compare

On 23/12/13 06:10, Ding Tianhong wrote:

[...]

> --- a/net/batman-adv/originator.c
> +++ b/net/batman-adv/originator.c
> @@ -41,7 +41,7 @@ int batadv_compare_orig(const struct hlist_node *node, const void *data2)
>  	const void *data1 = container_of(node, struct batadv_orig_node,
>  					 hash_entry);
>  
> -	return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
> +	return ether_addr_equal_unaligned(data1, data2) ? 1 : 0;

ether_addr_equal_unaligned() returns a bool value which is implicitly
converted to 1 or 0: there is no need for the ternary if anymore.


>  }
>  
>  /**
> diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
> index 4add57d..5e66d4b 100644
> --- a/net/batman-adv/translation-table.c
> +++ b/net/batman-adv/translation-table.c
> @@ -51,7 +51,7 @@ static int batadv_compare_tt(const struct hlist_node *node, const void *data2)
>  	const void *data1 = container_of(node, struct batadv_tt_common_entry,
>  					 hash_entry);
>  
> -	return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
> +	return ether_addr_equal_unaligned(data1, data2) ? 1 : 0;

same here


Moreover, include linux/etherdevice.h in both files as explained in
point 1) of Documentation/SubmitChecklist

Thanks.



Cheers,

-- 
Antonio Quartulli


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)