netdev - Re: [PATCH v2 06/20] ppp: slight optimization of addr compare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Dec 2013 20:40:46 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Joe Perches <joe@...ches.com>
CC:	Ding Tianhong <dingtianhong@...wei.com>,
	Michal Ostrowski <mostrows@...thlink.net>,
	Netdev <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 06/20] ppp: slight optimization of addr compare

Hello.

On 24-12-2013 20:35, Joe Perches wrote:

> []
>>> diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
> []
>>> @@ -131,12 +131,13 @@ static inline struct pppoe_net *pppoe_pernet(struct net *net)
>>>
>>>    static inline int cmp_2_addr(struct pppoe_addr *a, struct pppoe_addr *b)
>>>    {
>>> -	return a->sid == b->sid && !memcmp(a->remote, b->remote, ETH_ALEN);
>>> +	return a->sid == b->sid && ether_addr_equal(a->remote,
>>> +							      b->remote);

>>      If it really doesn't fit insto single line, the continuation line should
>> start right under 'a->remote'.

> Better still might be
>
> 	return a->sid == b->sid &&
> 	       ether_addr_equal(a->remote, b->remote);

    Actually, after the second look, I don't know why the line was broken at all.

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html