netdev - Re: [PATCH] macvlan: fix netdev feature propagation from lower device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 25 Dec 2013 11:30:36 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Florian Westphal <fw@...len.de>
CC:	<netdev@...r.kernel.org>, "Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH] macvlan: fix netdev feature propagation from lower
 device

On Tue, 2013-12-24 at 01:04 +0100, Florian Westphal wrote:
[...]
> --- a/drivers/net/macvlan.c
> +++ b/drivers/net/macvlan.c
[...]
> @@ -1010,7 +1021,12 @@ static int macvlan_device_event(struct notifier_block *unused,
>  		break;
>  	case NETDEV_FEAT_CHANGE:
>  		list_for_each_entry(vlan, &port->vlans, list) {
> -			vlan->dev->features = dev->features & MACVLAN_FEATURES;
> +			/* macvlan_fix_features will re-test current vlan
> +			 * features vs. lowerdev features.
> +			 */
> +			vlan->dev->features =
> +				macvlan_fix_features(vlan->dev,
> +						     vlan->dev->features);

You must call netdev_update_features() here and not set
net_device::features directly.

Ben.

>  			vlan->dev->gso_max_size = dev->gso_max_size;
>  			netdev_features_change(vlan->dev);
>  		}

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html