netdev - Re: [PATCH net-next 1/2] mlx4_en: Add PTP hardware clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131226091740.GA8787@netboy>
Date:	Thu, 26 Dec 2013 10:17:41 +0100
From:	Richard Cochran <richardcochran@...il.com>
To:	Hadar Hen Zion <hadarh@...lanox.com>
Cc:	Shawn Bohrer <shawn.bohrer@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Amir Vadai <amirv@...lanox.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"tomk@...advisors.com" <tomk@...advisors.com>,
	Shawn Bohrer <sbohrer@...advisors.com>
Subject: Re: [PATCH net-next 1/2] mlx4_en: Add PTP hardware clock

On Thu, Dec 26, 2013 at 10:33:26AM +0200, Hadar Hen Zion wrote:
> 
> Is there a way to time stamping packets per socket?

No, it is at the device level. Some devices support time stamping
different types of packets, like PTP events.

I looked again at your driver, and now it makes sense to me that the
spin lock is so costly in your tests. Every received packet calls
timecounter_cyc2time.  So you will need locking, and I think
reader/writer is perfectly fine for you to use.

Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html