netdev - Re: [PATCH] ipv6: shouldn't dump the expired routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131226094819.613cee5b@nehalam.linuxnetplumber.net>
Date:	Thu, 26 Dec 2013 09:48:19 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Duan Jiong <duanj.fnst@...fujitsu.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: shouldn't dump the expired routes

On Thu, 26 Dec 2013 14:00:25 +0800
Duan Jiong <duanj.fnst@...fujitsu.com> wrote:

> 
> If we execute the command "ip -6 route show table all", those routes
> that have been expired will be dumped.  But as everyone knows, those
> expired routes will not be used, and they will be deleted by the kernel.
> So why we still need to dump they, and just don't dump them.
> 
> Signed-off-by: Duan Jiong <duanj.fnst@...fujitsu.com>

I can see three issues with this patch.

1. You are changing output of iproute2, and there is a slim chance somebody is
   expecting those routes in some test script.

2. Developers maybe using this to check that the expiration of routes is really
   working.

3. By making rt6_check_expired a global symbol, it can't be optimized as well in
   a potentially hot path for routing.

I am not saying the patch shouldn't go in, just raising the possibility that such
a seemingly trivial change could cause other impacts.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html