[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1388095258.12212.37.camel@edumazet-glaptop2.roam.corp.google.com>
Date: Thu, 26 Dec 2013 14:00:58 -0800
From: Eric Dumazet <eric.dumazet@...il.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: Michael Dalton <mwdalton@...gle.com>,
Jason Wang <jasowang@...hat.com>,
"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
Eric Dumazet <edumazet@...gle.com>,
Rusty Russell <rusty@...tcorp.com.au>,
lf-virt <virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH net-next 2/3] virtio-net: use per-receive queue page
frag alloc for mergeable bufs
On Thu, 2013-12-26 at 23:37 +0200, Michael S. Tsirkin wrote:
> Interesting. But if we can't allocate a buffer how can we
> do network processing?
How typical NIC drivers handle this case ?
Answer : nothing special should happen, we drop incoming traffic,
and make sure the driver recovers properly. (like not NULL deref or
crazy things like that)
Why virtio_net should be different ?
>
> If we can reproduce the problem, we can maybe move
> allocation out of napi disabled section, but then
> we'll need to add more locking.
More exactly, use appropriate locking ;)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists