netdev - Re: [PATCH net-next v3 2/2] tipc: make the code look more readable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52BCDD0C.6030508@windriver.com>
Date:	Fri, 27 Dec 2013 09:51:08 +0800
From:	Ying Xue <ying.xue@...driver.com>
To:	Wang Weidong <wangweidong1@...wei.com>, <jon.maloy@...csson.com>,
	<allan.stephens@...driver.com>, <davem@...emloft.net>
CC:	<David.Laight@...LAB.COM>, <netdev@...r.kernel.org>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Subject: Re: [PATCH net-next v3 2/2] tipc: make the code look more readable

On 12/27/2013 09:45 AM, Wang Weidong wrote:
> In commit 3b8401fe9d ("tipc: kill unnecessary goto's") didn't make
> the code look most readable, so fix it. This patch is cosmetic
> and does not change the operation of TIPC in any way.
> 
> v3: fix the spelling error which pointed out by Sergei.
> 
> v2: fix the problem "Referring commit purely by
>     SHA1 ID is ambiguous" which pointed out by David.
> 

Please don't add review version history into patch head comments.


> Suggested-by: David Laight <David.Laight@...LAB.COM>
> Signed-off-by: Wang Weidong <wangweidong1@...wei.com>
> ---
>  net/tipc/socket.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/net/tipc/socket.c b/net/tipc/socket.c
> index 83f466e..5efdeef 100644
> --- a/net/tipc/socket.c
> +++ b/net/tipc/socket.c
> @@ -751,13 +751,10 @@ static int send_stream(struct kiocb *iocb, struct socket *sock,
>  
>  	/* Handle special cases where there is no connection */
>  	if (unlikely(sock->state != SS_CONNECTED)) {
> -		res = -ENOTCONN;
> -
>  		if (sock->state == SS_UNCONNECTED)
>  			res = send_packet(NULL, sock, m, total_len);
> -		else if (sock->state == SS_DISCONNECTING)
> -			res = -EPIPE;
> -
> +		else
> +			res = sock->state == SS_DISCONNECTING ? -EPIPE : -ENOTCONN;
>  		goto exit;
>  	}
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html