netdev - Re: [PATCH net] tcp: do not grow receive window if skb->len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1388124668.12212.51.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 26 Dec 2013 22:11:08 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Weiping Pan <panweiping3@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] tcp: do not grow receive window if skb->len < 128

On Fri, 2013-12-27 at 11:20 +0800, Weiping Pan wrote:
> Commit 4e4f1fc22681(tcp: properly increase rcv_ssthresh for ofo packets) can
> grow receive window for out of order packets,
> but for in order packets, we only call tcp_grow_window() if skb->len >= 128,
> I think we should add the same condition for out of order packets.
> 

Why do you think so ? Do you have any experimental data to share ?

I personally think the basic test in tcp_event_data_recv() is redundant
with the logic in tcp_grow_window()

skb->len < 128 seems a poor test, real factor is skb->len/skb->truesize
ratio.

Note: Please always CC a patch author when you mention a commit in
a changelog.

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html