netdev - Re: [PATCH net-next 1/3] net_sched: act: Dont increment refcnt on replace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20131227.125018.829521862249543338.davem@davemloft.net>
Date:	Fri, 27 Dec 2013 12:50:18 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jhs@...atatu.com
Cc:	netdev@...r.kernel.org, xiyou.wangcong@...il.com,
	eric.dumazet@...il.com
Subject: Re: [PATCH net-next 1/3] net_sched: act: Dont increment refcnt on
 replace

From: Jamal Hadi Salim <jhs@...atatu.com>
Date: Mon, 23 Dec 2013 08:02:11 -0500

>  This is a bug fix. The existing code tries to kill many
>  birds with one stone: Handling binding of actions to
>  filters, new actions and replacing of action
>  attributes. A simple test case to illustrate:
> 
> XXXX
>  moja@fe1:~$ sudo tc actions add action drop index 12
>  moja@fe1:~$ actions get action gact index 12        
>  action order 1: gact action drop
>   random type none pass val 0 
>   index 12 ref 1 bind 0
>  moja@fe1:~$ sudo tc actions replace action ok index 12
>  moja@fe1:~$ actions get action gact index 12        
>  action order 1: gact action drop
>   random type none pass val 0 
>   index 12 ref 2 bind 0
> XXXX
> 
> The above shows the refcounf being wrongly incremented on replace.
> There are more complex scenarios with binding of actions to filters
> that i am leaving out that didnt work as well...
> 
> Signed-off-by: Jamal Hadi Salim <jhs@...atatu.com>

Applied to 'net', thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html