netdev - Re: [PATCH] netxen: Correct off-by-one errors in bounds checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131227.130847.840672527417825080.davem@davemloft.net>
Date:	Fri, 27 Dec 2013 13:08:47 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	david@...son.dropbear.id.au
Cc:	manish.chopra@...gic.com, sony.chacko@...gic.com,
	rajesh.borundia@...gic.com, netdev@...r.kernel.org
Subject: Re: [PATCH] netxen: Correct off-by-one errors in bounds checks

From: David Gibson <david@...son.dropbear.id.au>
Date: Fri, 20 Dec 2013 15:10:44 +1100

> netxen_process_lro() contains two bounds checks.  One for the ring number
> against the number of rings, and one for the Rx buffer ID against the
> array of receive buffers.
> 
> Both of these have off-by-one errors, using > instead of >=. The correct
> versions are used in netxen_process_rcv(), they're just wrong in
> netxen_process_lro().
> 
> Signed-off-by: David Gibson <david@...son.dropbear.id.au>

Looks good, applied, thanks David.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html