lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 28 Dec 2013 13:05:49 +0800 From: Ding Tianhong <dingtianhong@...wei.com> To: Eric Dumazet <eric.dumazet@...il.com> CC: "David S. Miller" <davem@...emloft.net>, Netdev <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net-next 19/20] net: plip: slight optimization of addr compare On 2013/12/27 23:48, Eric Dumazet wrote: > On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote: >> Use possibly more efficient ether_addr_equal >> to instead of memcmp. >> >> Cc: "David S. Miller" <davem@...emloft.net> >> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com> >> --- >> drivers/net/plip/plip.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c >> index 7b4ff35..26614df 100644 >> --- a/drivers/net/plip/plip.c >> +++ b/drivers/net/plip/plip.c >> @@ -549,7 +549,7 @@ static __be16 plip_type_trans(struct sk_buff *skb, struct net_device *dev) >> >> if(*eth->h_dest&1) >> { >> - if(memcmp(eth->h_dest,dev->broadcast, ETH_ALEN)==0) >> + if(ether_addr_equal(eth->h_dest, dev->broadcast)) >> skb->pkt_type=PACKET_BROADCAST; >> else >> skb->pkt_type=PACKET_MULTICAST; > > What about : > > if (is_multicast_ether_addr(eth->h_dest)) { > if (ether_addr_equal_64bits(eth->h_dest, dev->broadcast)) > skb->pkt_type = PACKET_BROADCAST; > else > skb->pkt_type = PACKET_MULTICAST; > } > > > more better, thanks. Regards Ding > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists