netdev - Re: [PATCH iproute2] iptunnel: Allow GRE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131228113128.5898cdfe@nehalam.linuxnetplumber.net>
Date:	Sat, 28 Dec 2013 11:31:28 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Hangbin Liu <liuhangbin@...il.com>
Cc:	network dev <netdev@...r.kernel.org>,
	Steffen Klassert <steffen.klassert@...unet.com>
Subject: Re: [PATCH iproute2] iptunnel: Allow GRE_KEY for vti interface

On Fri,  6 Dec 2013 00:19:01 +0800
Hangbin Liu <liuhangbin@...il.com> wrote:

> The vti interface will use GRE_KEY to match the right policy in kernel. So we
> can not return fail when the tunnel is vti.
> 
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  ip/iptunnel.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ip/iptunnel.c b/ip/iptunnel.c
> index 40186d3..950f984 100644
> --- a/ip/iptunnel.c
> +++ b/ip/iptunnel.c
> @@ -240,8 +240,8 @@ static int parse_args(int argc, char **argv, int cmd, struct ip_tunnel_parm *p)
>  		}
>  	}
>  
> -	if (p->iph.protocol == IPPROTO_IPIP || p->iph.protocol == IPPROTO_IPV6) {
> -		if ((p->i_flags & GRE_KEY) || (p->o_flags & GRE_KEY)) {
> +	if ((p->i_flags & GRE_KEY) || (p->o_flags & GRE_KEY)) {
> +		if (!(p->i_flags & VTI_ISVTI) && (p->iph.protocol != IPPROTO_GRE)) {
>  			fprintf(stderr, "Keys are not allowed with ipip and sit tunnels\n");
>  			return -1;
>  		}

Accepted. Hope this works for everyone
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html