netdev - Re: [WARNING net-next] from ixgbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52C104C1.6070508@gmail.com>
Date:	Sun, 29 Dec 2013 21:29:37 -0800
From:	John Fastabend <john.fastabend@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
CC:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>, netdev@...r.kernel.org,
	e1000-devel@...ts.sourceforge.net
Subject: Re: [WARNING net-next] from ixgbe_configure

On 12/29/2013 01:15 PM, Stephen Hemminger wrote:
> Warning with current net-next from ixgbe_configure calling
> netdev_all_upper_get_next_dev_rcu without RCU read lock held.
>
>
> [    4.717512] r8169 0000:03:00.0 eth0: link down
> [    4.717581] r8169 0000:03:00.0 eth0: link down
> [    4.717590] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
> [    6.722390] r8169 0000:03:00.0 eth0: link up
> [    6.722428] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
> [    9.833968] ------------[ cut here ]------------
> [    9.833976] WARNING: CPU: 5 PID: 2173 at net/core/dev.c:4448 netdev_all_upper_get_next_dev_rcu+0x6b/0xa0()


This should be fixed when net is synced with net-next by the
following commit,

author		John Fastabend <john.r.fastabend@...el.com>
committer	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
commit		85328240c625f322af9f69c7b60e619717101d77

net: allow netdev_all_upper_get_next_dev_rcu with rtnl lock held

It is useful to be able to walk all upper devices when bringing a device 
online where the RTNL lock is held. In this case it is safe to walk the 
all_adj_list because the RTNL lock is used to protect the write side as 
well.
[...]

Thanks,
John

-- 
John Fastabend         Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html