netdev - Re: [net-next bugfix] net, rps: fix build failure when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131231.160851.1101721532410450212.davem@davemloft.net>
Date:	Tue, 31 Dec 2013 16:08:51 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sergei.shtylyov@...entembedded.com
Cc:	zwu.kernel@...il.com, netdev@...r.kernel.org, therbert@...gle.com,
	fengguang.wu@...el.com, wuzhy@...ux.vnet.ibm.com
Subject: Re: [net-next bugfix] net, rps: fix build failure when CONFIG_RPS
 isn't set

From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Wed, 01 Jan 2014 01:03:18 +0300

> Hello.
> 
> On 12/31/2013 11:31 PM, Zhi Yong Wu wrote:
> 
>> From: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
> 
>> Reported-by: Fengguang Wu <fengguang.wu@...el.com>
>> Signed-off-by: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
>> ---
>>   include/net/sock.h |    4 ++++
>>   1 files changed, 4 insertions(+), 0 deletions(-)
> 
>> diff --git a/include/net/sock.h b/include/net/sock.h
>> index 8ee90ad..bd716b6 100644
>> --- a/include/net/sock.h
>> +++ b/include/net/sock.h
>> @@ -846,12 +846,16 @@ static inline void
>> sock_rps_reset_flow_hash(__u32 hash)
>>
>>   static inline void sock_rps_record_flow(const struct sock *sk)
>>   {
>> +#ifdef CONFIG_RPS
>>   	sock_rps_record_flow_hash(sk->sk_rxhash);
>> +#endif
>>   }
>>
>>   static inline void sock_rps_reset_flow(const struct sock *sk)
>>   {
>> +#ifdef CONFIG_RPS
>>   	sock_rps_reset_flow_hash(sk->sk_rxhash);
>> +#endif
>>   }
> 
>    A lot better style would be:

Sorry, I meant to say, this is consistent with how the other functions
dependent upon RPS are handled.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html