netdev - Re: [PATCH net-next v3 00/19] slight optimization of addr compare for net modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131231.164912.1373331336904065031.davem@davemloft.net>
Date:	Tue, 31 Dec 2013 16:49:12 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dingtianhong@...wei.com
Cc:	joe@...ches.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, sergei.shtylyov@...entembedded.com,
	edumazet@...gle.com
Subject: Re: [PATCH net-next v3 00/19] slight optimization of addr compare
 for net modules

From: Ding Tianhong <dingtianhong@...wei.com>
Date: Mon, 30 Dec 2013 15:40:25 +0800

> This is the second patchset for slight optimization of address compare,
> mainly for net tree, just following the Joe's opinion, it will help review
> the code for maintainers and supports.
> 
> v2: Change some style for patch 2.
>     According Eric's suggestion, use the ether_addr_equal_64bits to instead
>     of ether_addr_equal for patch 19.
>     In fact, there are a lot of places which could use ether_addr_equal_64bits
>     to instead of ether_addr_equal, but not this time, thanks for Joe's
>     opinion.
> 
> v3: Change some style for patch 11/19:
>     (net: packetengines: slight optimization of addr compare).
>     Joe pointed out that is_broadcast_ether_addr(addr) would be appropriate here,
>     but this should be left alone and not in this patch, so fix it later.
> 
>     In the patch (net: caif: slight optimization of addr compare), the operand for
>     memcmp is not mac address, so it is unsuitable to use the ether_addr_equal
>     to compare a non mac address, so remove the patch from the series.

Series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html