netdev - Re: [PATCH 5/5] alx: add stats to ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1388668154.4326.1.camel@jlt4.sipsolutions.net>
Date:	Thu, 02 Jan 2014 14:09:14 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Sabrina Dubroca <sd@...asysnail.net>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH 5/5] alx: add stats to ethtool

On Thu, 2014-01-02 at 00:40 +0100, Sabrina Dubroca wrote:

> +static const char alx_gstrings_stats[][ETH_GSTRING_LEN] = {

You should probably have a comment here and on the stats struct
declaration that they must absolutely match in order/size/etc.

Maybe try to put in some BUILD_BUG_ON() as well, at least checking the
sizeof() vs. ARRAY_SIZE*sizeof(u64) - that might already have caught the
bug that Ben pointed out.

> +	"rx_packets",

Is it useful to provide stats that are already elsewhere? Then again, it
doesn't really hurt and simplifies the code ...

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html