netdev - question about tulip/winbond-840.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1401021520280.2088@hadrien>
Date:	Thu, 2 Jan 2014 15:24:49 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	grundler@...isc-linux.org
cc:	netdev@...r.kernel.org
Subject: question about tulip/winbond-840.c

I don't know if you want to bother about this, because it is very old code
and is apparently not hurting anyone, but I don't see the point of the
call to pci_enable_device in the function w840_resume.  The driver had a
call to pci_enable_device in its probe function, but it contains no call
to pci_disable_device, unlike some other tulip drivers.  Perhaps the call
has a small functionality, but it seems like it can at least never return
a value other than 0, because the result of
atomic_inc_return(&dev->enable_cnt) in pci_enable_device_flags should
be greater than 1.

julia
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html